Fix issue #214, error when converting tad to ad #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output after the fix ``` $ dng-pileup pTest1.ad -o pTest1a2t.tad $ dng-pileup pTest1.tad -o pTest1t2a.ad $ diff -s pTest1.ad pTest1t2a.ad Files pTest1.ad and pTest1t2a.ad are identical $ diff -s pTest1.tad pTest1a2t.tad Files pTest1.tad and pTest1a2t.tad are identical ``` The segmentation fault was cause at line 828 in `ad.cc` -> `last_data_[i] = line.data()[i];` Where `last_data_` in `io::Ad output` was not initilised.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output after the fix
The segmentation fault was cause at
line 828 in
ad.cc->last_data_[i] = line.data()[i];Where
last_data_inio::Ad outputwas not initilised.