Use native virtual-text for vim9

[vimpostor]

This reimplements virtual text for vim with the new native virtual text API. Please see the commit message for more details.

When this gets merged, I can finally tackle #2962 and implement multiple virtual texts being visible at once.

Screenshot

Before: At the top (implementation is a bit janky)
After: At the bottom (jank is fixed with native virtual text)

[hsanson]

Looks good but I can only verify it does not break things in neovim. Would be great if someone, that is not the PR author, can verify it works as expected in vim.

[vimpostor]

Would be great if someone can verify it works as expected in vim.

I am a someone and I can verify it works in vim. ^^

@blayz3r You linked in the issue to the new vim9 implementation, would you mind compiling latest vim from source and verifying that everything works as expected with this PR?

[darkseid-is]

Needs bug fixes .

1. Underline remains even after fixing the error
   

2. Not working as expected in general
   

vim version : 9.0.228

ale settings
let g:ale_linters = {'rust': ['analyzer']}
let g:ale_fixers = { 'rust': ['rustfmt', 'trim_whitespace', 'remove_trailing_lines'] }
let g:ale_fix_on_save = 1
let g:ale_sign_error = '✗'
let g:ale_sign_warning = ''
let g:ale_sign_column_always = 1
let g:ale_rust_cargo_use_clippy = 1
let g:ale_completion_enabled = 1

let g:ale_virtualtext_cursor = 1
let g:ale_virtualtext_delay = 1

[vimpostor]

Needs bug fixes .

1. Underline remains even after fixing the error
2. Not working as expected in general

Cannot reproduce any of these problems with your config. Please provide a minimal working config to reproduce the problem.

The part of your config that you shared, does not reproduce the problem with a clean config as can be tested with:

vim --clean -Nu <(cat<<EOF
set rtp+=/path/to/ale/with/my/branch/checkedout
let g:ale_linters = {'rust': ['analyzer']}
let g:ale_fixers = { 'rust': ['rustfmt', 'trim_whitespace', 'remove_trailing_lines'] }
let g:ale_fix_on_save = 1
let g:ale_sign_error = '✗'
let g:ale_sign_warning = ''
let g:ale_sign_column_always = 1
let g:ale_rust_cargo_use_clippy = 1
let g:ale_completion_enabled = 1

let g:ale_virtualtext_cursor = 1
let g:ale_virtualtext_delay = 1

au BufEnter *.rs set ft=rust
EOF
) /path/to/main.rs

[darkseid-is]

vimrc
``
filetype plugin indent on
filetype plugin on
set autoread
set backspace=indent,eol,start
set belloff=all
set clipboard=unnamedplus
set colorcolumn=80
set cursorline
set display+=lastline "prevent @ symbol from being shown
set encoding=utf8
set expandtab
set foldlevel=99
set foldmethod=indent
set ignorecase
set incsearch
set modelines=0
set noautochdir
set nocompatible
set nomodeline
set noshowmode
set number
set path+=**
set scrolloff=15
set showcmd
set signcolumn=yes
set smartcase
set smartindent
set splitbelow
set splitright
set tags+=tags;/
set ttyfast
set updatetime=50
set viminfo=
set wildmenu
set wildmode=list:longest,full
syntax on
set wildoptions=pum
set wildcharm=
set completepopup=height:10,width:60,highlight:InfoPopup

set t_Co=256
set background=dark
set termguicolors " enable true colors support
let ayucolor="dark" " for dark version of theme
colorscheme ayu
hi ColorColumn ctermbg=darkgrey " Colorcolumn
hi Comment ctermfg=yellow " Comment
hi Folded ctermbg=yellow " Folds
hi Normal ctermbg=NONE guibg=NONE
hi StatusLine ctermfg=green ctermbg=black guifg=green guibg=black " Focused
hi StatusLineNC ctermfg=grey ctermbg=black guifg=Grey guibg=black " NonFocused
hi TabLine ctermfg=grey ctermbg=black guifg=grey guibg=black " Inactive
hi TabLineFill ctermfg=grey ctermbg=black guifg=Black guibg=black " NoLabled
hi TabLineSel ctermfg=grey ctermbg=black guifg=Red guibg=black " Active

packloadall
silent! helptags ALL
let g:ale_linters = {'rust': ['analyzer']}
let g:ale_fixers = { 'rust': ['rustfmt', 'trim_whitespace', 'remove_trailing_lines'] }
let g:ale_fix_on_save = 1
let g:ale_sign_error = '✗'
let g:ale_sign_warning = ''
let g:ale_sign_column_always = 1
let g:ale_rust_cargo_use_clippy = 1
let g:ale_completion_enabled = 1

let g:ale_virtualtext_cursor = 1
let g:ale_virtualtext_delay = 0
``

Cursor is in line 7 and virtual text is shown in line 3.

[vimpostor]

That config is neither minimal, nor does it reproduce the problem on my system.

It is not even a valid config, for example the line with set wildcharm= is not valid, because wildcharm expects a number.

There are other problems with that config too so please provide a minimal config, that actually reproduces the problem.

Also are you sure that you have checked out my branch? Your problem sounds more like something that could happen with the legacy virtual text implementation.

[darkseid-is]

Sorry for posting buggy rc.
cloned repo from https://github.com/vimpostor/ale
git branch native_virt_text

minimal working rc
filetype plugin indent on
filetype plugin on
syntax on
set number
colorscheme desert

packloadall
silent! helptags ALL
let g:ale_linters = {'rust': ['analyzer']}
let g:ale_fixers = { 'rust': ['rustfmt', 'trim_whitespace', 'remove_trailing_lines'] }
let g:ale_fix_on_save = 1
let g:ale_sign_error = '✗'
let g:ale_sign_warning = ''
let g:ale_sign_column_always = 1
let g:ale_rust_cargo_use_clippy = 1
let g:ale_completion_enabled = 1

let g:ale_virtualtext_cursor = 1
let g:ale_virtualtext_delay = 1

[vimpostor]

cloned repo from https://github.com/vimpostor/ale git branch native_virt_text packloadall

That is not enough to load the checkout of the plugin. You still need to add it to the runtimepath, it seems you are loading the plugin from somewhere else. And your minimal config still does not reproduce the problem, I have proven it in the following recording: https://asciinema.org/a/isJpN089bx4RFZXbHoq9VeVSG I still think that you are testing with the wrong version of Ale because "packloadall" does not load my branch if you do not add it to the runtimepath. If you still think you are testing it the correct way, then please attach a recording showing exactly how you start vim with my branch checked out.

[darkseid-is]

Setting rtp fixed the issue.

[vimpostor]

Setting rtp fixed the issue.

Thanks, so it looks like you used the wrong checkout of Ale all along.
If you confirm that now everything is working correctly, then I guess @hsanson could merge it in.

I just pushed my patch again restricting it to at least vim 9.0.0214, because there were a lot of virtual text bugfixes in vim since its initial implementation.

[darkseid-is]

Setting rtp fixed the issue.

Thanks, so it looks like you used the wrong checkout of Ale all along. If you confirm that now everything is working correctly, then I guess @hsanson could merge it in.

I just pushed my patch again restricting it to at least vim 9.0.0214, because there were a lot of virtual text bugfixes in vim since its initial implementation.

Yes, I can confirm it works as expected.
Keep up the good work mate.

[hsanson]

Thanks for the contribution and testing.