Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template switching not working on AV entities #123

Closed
sarabeckman opened this issue Mar 6, 2019 · 3 comments
Closed

Template switching not working on AV entities #123

sarabeckman opened this issue Mar 6, 2019 · 3 comments
Assignees
Labels

Comments

@sarabeckman
Copy link
Collaborator

When indexing ddr-csujad-29, ddr-csujad-30, and ddr-csujad-31 using ddrlocal-develop_2.6.8w I noticed the AV entities weren't displaying as we had discussed.

The 'download transcript' button wasn't on the page etc. Looking closer there is no template attribute https://ddrstage.densho.org/api/0.2/ddr-csujad-29-54/ (see ddr-csujad-28-1 for comparison https://ddrstage.densho.org/api/0.2/ddr-csujad-28-1/)

@GeoffFroh
Copy link
Member

Sara tested indexing with ddr-csujad-29 and ddr-csujad-28. The indexer seemed to add the template attribute for ddr-csujad-28 (see link above), but did not for ddr-csujad-54.

Both entities are type = av, with a single mezzanine file with mimetype = audio/mpeg

see: ddr-csujad-28-1-mezzanine-93bba06d9c.json and ddr-csujad-29-54-mezzanine-66b5f55aaf.json

@gjost
Copy link
Member

gjost commented Mar 12, 2019

When indexing objects for publication, the template attribute is added in DDR.models.common line 395. This line is only executed if the object has a corresponding record at Internet Archive (see line 387).

With the current code, if records are not uploaded to IA then it is impossible for objects to have an A/V template.

@GeoffFroh
Copy link
Member

Confirmed IA-dependent behavior. Will leave as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants