Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abstractions that represent application logic #152

Closed
MrDave1999 opened this issue Jan 29, 2023 · 0 comments · Fixed by #157
Closed

Remove abstractions that represent application logic #152

MrDave1999 opened this issue Jan 29, 2023 · 0 comments · Fixed by #157
Labels
refactor Refactoring existing code, to make it more readable, cleaner or more efficient

Comments

@MrDave1999
Copy link
Member

MrDave1999 commented Jan 29, 2023

The abstraction is only used once and has only one implementation associated with it. This only adds unnecessary complexity to the project and complicates maintenance, since changes must be made to both the abstraction and the concrete class when a new method needs to be added.

@MrDave1999 MrDave1999 added the refactor Refactoring existing code, to make it more readable, cleaner or more efficient label Jan 29, 2023
@MrDave1999 MrDave1999 linked a pull request Feb 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring existing code, to make it more readable, cleaner or more efficient
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant