Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streak Reset for no reason #83

Closed
janaSunrise opened this issue Apr 20, 2021 · 6 comments · Fixed by #85
Closed

Streak Reset for no reason #83

janaSunrise opened this issue Apr 20, 2021 · 6 comments · Fixed by #85
Labels
bug Something isn't working

Comments

@janaSunrise
Copy link

Describe the bug
I'm contributing and coding everyday, but today it reset all of a sudden for no reason.

Expected behavior
It was supposed to continue

Screenshots
My contribution graph:
Screenshot from 2021-04-20 20-37-47

My stats card:
Screenshot from 2021-04-20 20-39-44

Desktop (please complete the following information):

  • OS: Linux (Ubuntu)
  • Browser: Firefox
  • Version: latest

Additional context
Add any other context about the problem here.

@janaSunrise janaSunrise added the bug Something isn't working label Apr 20, 2021
@janaSunrise
Copy link
Author

Got it fixed by re-adding, Thank you, and sorry!!

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Apr 20, 2021

Hi @janaSunrise

It looks like this may have been caused by a commit that you have on October 16, 2021.

image

October 16 is the last item in the generated list so it is treated as the current date and it becomes the current streak.

I think it might make more sense to simply make Streak Stats ignore commits after the current date so the current streak makes more sense.

@janaSunrise
Copy link
Author

Oh, weird! I didnt notice that, I'll try to figure that and fix it! Thanks for your immediate help, Appreciate it! :D

@DenverCoder1
Copy link
Owner

@janaSunrise I only now noticed that you mentioned that you wanted to fix it. Sorry if I took away the opportunity by making the change to the code.

With the new code, your card should display like this with the end date being today's date (UTC)

image

It may take some time for the cached version to get refreshed by GitHub.

Let me know if you have any ideas on ways it can be improved further! 😃

@janaSunrise
Copy link
Author

Ah great 😁 I'll find another issue to work on later then! For now everything's all good! Thanks for the great response!

@Rafath-Auvee
Copy link

I lost my streak. No reason at all. How do you fix it? @janaSunrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants