Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme-driven development #5

Merged
merged 2 commits into from
Dec 3, 2015
Merged

readme-driven development #5

merged 2 commits into from
Dec 3, 2015

Conversation

iamstarkov
Copy link
Contributor

rewrite readme, simplify tests

@iamstarkov
Copy link
Contributor Author

/cc @denysdovhan @shuvalov-anton @kinday

@iamstarkov
Copy link
Contributor Author

You maybe interested in actual README and rewritten tests

@iamstarkov
Copy link
Contributor Author

@denysdovhan sorry for almost entirely rewritten readme

denysdovhan
denysdovhan reviewed Dec 2, 2015
View reviewed changes
README.md
@@ -7,56 +7,61 @@

> [Mdast][mdast] plugin for [Textr][textr] — modular tool to [make your typography better][typewriter-habits].

This plugin will help you to transform only _text_ nodes from your markdown using any functions that get text, transform it and return result of processing. For example, check out [typographic-*][tfs] functions. All of those functions are being composed using [Textr][textr].
Process your markdown with [Textr][textr] plugins, **skipping code**.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think install ref also sould be here.

@denysdovhan
Copy link
Collaborator

looks nice. please fix typos

@iamstarkov
Copy link
Contributor Author

done

@denysdovhan
Copy link
Collaborator

Why did build crash?

@iamstarkov
Copy link
Contributor Author

dunno, I just updated readme from latest successful build

@iamstarkov
Copy link
Contributor Author

what does Travis say?

@iamstarkov
Copy link
Contributor Author

it's just awkward 0.10 error. please restart this build https://travis-ci.org/denysdovhan/mdast-textr/jobs/94596212

@iamstarkov iamstarkov closed this Dec 3, 2015
@iamstarkov iamstarkov reopened this Dec 3, 2015
@iamstarkov
Copy link
Contributor Author

Lol, its because Promises are not supported in 0.10

@iamstarkov
Copy link
Contributor Author

can you remove 0.10 from travis config and then I will rebase my pull-request

@denysdovhan
Copy link
Collaborator

can you remove 0.10 from travis

done. btw, please give your commits more informative messages.

@iamstarkov
Copy link
Contributor Author

sure, done. those commits were just wip commits

@denysdovhan
Copy link
Collaborator

lgtm

denysdovhan added a commit that referenced this pull request Dec 3, 2015
@denysdovhan
Merge pull request #5 from iamstarkov/docs/cli
8b5cb68 
Readme-driven development.
@denysdovhan denysdovhan merged commit 8b5cb68 into remarkjs:master Dec 3, 2015
@denysdovhan
Copy link
Collaborator

nice work. thank you!
Check your email, I'm gonna send you collaboration invite ;)

@wooorm wooorm added ⛵️ status/released 📚 area/docs This affects documentation 🦋 type/enhancement This is great to have labels Aug 14, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamstarkov @denysdovhan @wooorm