fix: card-mod not working #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
denysdovhan
approved these changes
Oct 3, 2023
denysdovhan
reviewed
Oct 3, 2023
Co-authored-by: Denys Dovhan <denysdovhan@gmail.com>
|
So I pushed changes to pass the remaining properties of config using the spread operator and I've tested it and it's working. |
denysdovhan
requested changes
Oct 3, 2023
|
You're totally right. Thank you for code reviewing, this operator is completely new for me. |
denysdovhan
approved these changes
Oct 3, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
## [2.5.1](v2.5.0...v2.5.1) (2023-10-03) ### Bug Fixes * card-mod not working ([#247](#247)) ([4df2497](4df2497))
|
🎉 This PR is included in version 2.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've created this pull request to fix the functionality issue with the card-mod as mentioned in issue #234.
I've added
styleandcard_modoption properties. These are required to consist inconfigobject for card-mod to read them and create styles.Please review and provide feedback.
And thank you for your amazing work.