Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prompt setup when loaded using zsh prompt function #275

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Fix prompt setup when loaded using zsh prompt function #275

merged 1 commit into from
Jan 11, 2018

Conversation

belak
Copy link
Contributor

@belak belak commented Dec 11, 2017

This is very similar to Powerlevel9k/powerlevel9k@f46c1bc

It's based off code in zsh itself. prompt_opts are used when the prompt was loaded via promptinit/prompt and the setopt is a workaround for oh-my-zsh to ensure all the proper prompt options are set.

@denysdovhan
Copy link
Member

Wow, didn't know about it. Would it affect users that use $ZSH_THEME with OMZ?

@denysdovhan denysdovhan added the improvement A PR that make small changes for improving UX, performance, readability, etc label Dec 18, 2017
@denysdovhan denysdovhan added this to the v3.0 milestone Dec 18, 2017
@belak
Copy link
Contributor Author

belak commented Dec 18, 2017

Possibly, but probably not. OMZ doesn't end up calling prompt so these options don't get reset. Additionally, I think prompt_subst is set every time the title is updated (I'm not familiar with OMZ very much, as I work on prezto, but this looks relevant: https://github.com/robbyrussell/oh-my-zsh/blob/3705d47bb3f3229234cba992320eadc97a221caf/lib/termsupport.zsh), so at least that will be enabled.

@belak
Copy link
Contributor Author

belak commented Jan 8, 2018

I've added some additional background as to why this doesn't show up in OMZ here: zsh-users/antigen#539 (comment)

@denysdovhan denysdovhan merged commit 2e7abd3 into spaceship-prompt:3.0 Jan 11, 2018
@denysdovhan
Copy link
Member

Thanks for contributing! Merged in #148. A further conversation should continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Development

Successfully merging this pull request may close these issues.

None yet

2 participants