Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions scripts - are these magically created? #46

Closed
nickdos opened this issue May 14, 2020 · 6 comments
Closed

Actions scripts - are these magically created? #46

nickdos opened this issue May 14, 2020 · 6 comments
Labels
question Further information is requested

Comments

@nickdos
Copy link

nickdos commented May 14, 2020

The readme mentions that the actions config requires a service value in the form of: service: script.clean_living_room.

What is not clear, is how someone is to create these script files. I presume that the user has to create these, so it would be nice to provide some hints/links to the user on how to create these files.

@cschriel
Copy link
Contributor

The service_data in the actions object isn't required. By default it uses the "normal" method of starting the vacuum. Using this object, you can change what service gets triggered by using the action button.

@nickdos
Copy link
Author

nickdos commented May 14, 2020

Thanks - I get that its option but I want it!

What I don't know, is how do I setup my vacuum to do zone cleaning via the script.clean_my_room method? There is nothing in the readme.md about how to do this.

@royto
Copy link
Contributor

royto commented May 14, 2020

I used this article as inspiration when I created my scripts: https://hackernoon.com/how-i-set-up-room-cleaning-automation-with-google-home-home-assistant-and-xiaomi-vacuum-cleaner-9149e0267e6d

@denysdovhan
Copy link
Owner

There is nothing in the readme.md about how to do this.

It shouldn't be in readme. This is not part of this project, but rather the part of HA and its integrations.

@denysdovhan denysdovhan added the question Further information is requested label May 14, 2020
@nickdos
Copy link
Author

nickdos commented May 14, 2020

There is nothing in the readme.md about how to do this.

It shouldn't be in readme. This is not part of this project, but rather the part of HA and its integrations.

I'd argue, that if your plugin depends upon an integration being installed, then the README should link through to the documentation for that integration/s.

I looked on https://www.home-assistant.io/integrations/vacuum.xiaomi_miio/ and there is no mention of script anywhere on that page. I'm still unclear what needs to be in the scripts to trigger zone cleaning. Looking at the vacuum.xiaomi_miio page, I can see examples for automations... is the idea that I create scripts that are equivalent to the zone cleaning automations?

EDIT: I initially searched that page for 'script' and got no results - I must've had a typo. Carefully reading the page again, I found the example. FYI when I installed my vacuum, scripts weren't in HA yet, so please excuse my ignorance of them.

Scripts are quite new to HA, so I don't think you can assume average users know how to set them up.

@denysdovhan
Copy link
Owner

Let's add a link to scripts docs in README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants