New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseInt octals issue was fixed by ES5 #10

Closed

qgustavor opened this issue Jul 31, 2017 · 1 comment

Labels

qgustavor commented Jul 31, 2017

As in MDN "ECMAScript 5 removes octal interpretation". ES5 compatibility table shows only Konq 4.14 and obsolete platforms (Opera 12 and older, IE 8 and older, and Rhino) still have this issue.

Not related to octals, but something to add on:

// parseInt always convert input to string:
parseInt({toString: () => 2, valueOf: () => 1}) // -> 2
Number({toString: () => 2, valueOf: () => 1}) // -> 1

denysdovhan added improvement new-example labels

Owner

denysdovhan commented Aug 7, 2017

Hi, @qgustavor ! Thanks for reaching out!

Could you make a PR?

denysdovhan closed this as completed in

fd3f1d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment