Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korean translation #174

Closed
wants to merge 1 commit into from
Closed

Korean translation #174

wants to merge 1 commit into from

Conversation

fgo0615
Copy link

@fgo0615 fgo0615 commented Dec 15, 2020

reference #154
I finished translating into korean

@fgo0615
Create README-kr
e87ccd1 
reference denysdovhan#154 
I finished translating into korean
@fgo0615
Copy link
Author

fgo0615 commented Dec 16, 2020

Could you please review and merge or comment what sould i do next?

denysdovhan
denysdovhan reviewed Feb 3, 2021
View reviewed changes
Copy link
Owner

@denysdovhan denysdovhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should find someone who speaks Korean to read your translation and check for typos and mistakes.

@denysdovhan denysdovhan added the translation Translation requests label Feb 3, 2021
@denysdovhan denysdovhan changed the title Create README-kr Korean translation Feb 3, 2021
@denysdovhan denysdovhan added the help wanted We're looking for help on this issue or PR label Feb 4, 2021
@denysdovhan denysdovhan mentioned this pull request Feb 5, 2021
Closed
TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
@@ -0,0 +1,1784 @@
# What the f\*ck JavaScript?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니 X발? 자바스크립트 이게 뭐야??

The title needs to be translated.

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
$ npm install -g wtfjs
```

이제 당신은 커맨드 창에서 'wtfjs'를 실행할 수 있게 되었습니다. 당신이 선택한 '$PAGER'에서 열릴 것 입니다. 그렇지 않으면 계속 여기서 읽어도 됩니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

당신이 선택한 '$PAGER'에서 열릴 것 입니다
당신이 선택한 '$PAGER'에서 'wtfjs'가 열릴 것 입니다.

Slightly more elaborated expression.

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
- [Português do Brasil](./README-pt-br.md)
- [Polski](./README-pl-pl.md)
- [Italiano](./README-it-it.md)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs korean.md in case of approval

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
[**다른 번역 **][tr-request]

[tr-request]: https://github.com/denysdovhan/wtfjs/issues/new?title=Translation%20Request:%20%5BPlease%20enter%20language%20here%5D&body=I%20am%20able%20to%20translate%20this%20language%20%5Byes/no%5D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

38~40 is outdated.
It is different from what the original says

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
# 목차

- [💪🏻 Motivation](#-motivation)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>💪🏻 Motivation

💪🏻 시작하기에 앞서

It needs to be translated.

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
# 목차

- [💪🏻 Motivation](#-motivation)
- [✍🏻 Notation](#-notation)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍🏻 Notation
✍🏻 표기법

It needs to be translated.

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
- [true는 false이다](#true-is-false)
- [baNaNa](#banana)
- [`NaN`은 `NaN`이 아니다](#nan-is-not-a-nan)
- [이것은 실패다](#its-a-fail)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omitted Object.is() and === weird cases

better be

[Object.is()와 ===에 있어서 이상한 경우들]

TERADA-DANTE
TERADA-DANTE reviewed Feb 20, 2021
View reviewed changes
README-kr
- [이것은 실패다](#its-a-fail)
- [`[]`은 truthy이지만 `true`은 아니다](#-is-truthy-but-not-true)
- [`null`은 falsy이지만 `false`은 아니다](#null-is-falsy-but-not-false)
- [`document.all`은 객체이지만 정의되지 않았다](#documentall-is-an-object-but-it-is-undefined)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.all은 객체이지만 정의되지 않았다
document.all은 객체이지만 undefined이다

Slightly more Intuitive

@TERADA-DANTE
Copy link
Contributor

@denysdovhan Good day!
I found your fabulous repo and decide to contribute.
FYI, I am a native speaker of korean and japanese.

Thanks to @fgo0615 , for his amazing translation on korean, I've check it and guarantee you that It deserves to be merged.

Still it has some missings(not typo error, just omitted due to main branch update.), I'd like to add some to recover. In this case, Do I still need a cover-up man to verify it?

@denysdovhan
Copy link
Owner

@fgo0615 please, apply suggestions from @TERADA-DANTE.

@TERADA-DANTE please, collaborate with @fgo0615 on adding new examples.

TERADA-DANTE added a commit to TERADA-DANTE/wtfjs that referenced this pull request Feb 28, 2021
@TERADA-DANTE
🩹 Apply suggestions from denysdovhan#174
15e6920
@TERADA-DANTE TERADA-DANTE mentioned this pull request Feb 28, 2021
Merged
denysdovhan pushed a commit that referenced this pull request Mar 10, 2021
@TERADA-DANTE
feat: Korean translation (#201)
58cc055 
* 📝 Create README-kr.md

* ➕ Add README-kr.md in README.md #Tranlation

* 🩹 Apply suggestions from #174
github-actions bot pushed a commit that referenced this pull request Mar 10, 2021
@semantic-release-bot
chore(release): 1.21.0 [skip ci]
44d0191 
# [1.21.0](v1.20.1...v1.21.0) (2021-03-10)

### Features

* Korean translation ([#201](#201)) ([58cc055](58cc055)), closes [#174](#174)
@denysdovhan
Copy link
Owner

Already translated by #201

This was referenced Sep 15, 2021
Open
Open
Open
@dee123437 dee123437 mentioned this pull request May 13, 2022
Open
@dineshvgp dineshvgp mentioned this pull request May 13, 2022
Open
@avdkishore avdkishore mentioned this pull request May 14, 2022
Open
@dee123437 dee123437 mentioned this pull request Jun 23, 2022
Open
@avdkishore avdkishore mentioned this pull request Jun 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@avdkishore avdkishore mentioned this pull request Jun 21, 2023
Open
@dee123437 dee123437 mentioned this pull request Jun 21, 2023
Open
@dineshvgp dineshvgp mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan left review comments

@TERADA-DANTE TERADA-DANTE TERADA-DANTE left review comments

Assignees
No one assigned
Labels
help wanted We're looking for help on this issue or PR translation Translation requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgo0615 @TERADA-DANTE @denysdovhan