Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammatical issues from Korean translation #205

Merged
merged 1 commit into from Jun 7, 2021
Merged

Fix grammatical issues from Korean translation #205

merged 1 commit into from Jun 7, 2021

Conversation

stevejkang
Copy link
Contributor

@stevejkang stevejkang commented Mar 28, 2021 •
edited

I recently found out that a Korean translation of wtfjs was created, and it was harder to read than I thought, as it was written by a non-native speaker, and the 'translation tone' seemed to remain. Therefore, I tried to make the translation easier to read by enhancing the translation a little bit more.

The major changes are as follows.

  • When 'postposition'(like 은/는/이/가/을/를) is placed behind English words or English words wrapped in backticks, unnecessary spaces are removed.
  • It is the same word, but the parts used differently depending on the location are modified.
  • There were many problems with spacing, so they were corrected.
  • The sentence ends awkwardly modified.
  • Other grammatically correct typos or errors.

@stevejkang
Copy link
Contributor Author

Could you review this PR? @denysdovhan

@denysdovhan denysdovhan added translation Translation requests typo A typo in content labels Jun 7, 2021
@denysdovhan denysdovhan merged commit e1b8200 into denysdovhan:master Jun 7, 2021
github-actions bot pushed a commit that referenced this pull request Jun 7, 2021
@semantic-release-bot
chore(release): 1.21.2 [skip ci]
0778f2a 
## [1.21.2](v1.21.1...v1.21.2) (2021-06-07)

### Bug Fixes

* grammatical issues from Korean translation ([#205](#205)) ([e1b8200](e1b8200))
* typo ([#203](#203)) ([2e00b3d](2e00b3d))
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

🎉 This PR is included in version 1.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issues and PRs released by semantic-release label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan approved these changes

Assignees
No one assigned
Labels
released Issues and PRs released by semantic-release translation Translation requests typo A typo in content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevejkang @denysdovhan