Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail tasks leave Root Task on hold #12644

Closed
1 of 2 tasks
pkarman opened this issue Nov 7, 2019 · 4 comments
Closed
1 of 2 tasks

Mail tasks leave Root Task on hold #12644

pkarman opened this issue Nov 7, 2019 · 4 comments
Labels
Eng: Data Mark when data has been backfilled, or the issue has any data integrity concerns Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: Bug

Comments

@pkarman
Copy link
Contributor

pkarman commented Nov 7, 2019 •
edited by lomky

As discovered in #12238 and discussed in https://dsva.slack.com/archives/CJL810329/p1573140116295400 in some cases we appear to be opening Mail Tasks post-dispatch and leaving the Root Task open in on_hold status indefinitely. We should fix that.

AC

  • When all tasks are closed on an Appeal, make sure the Root Task also closes.
  • Clean up (close) existing Root Task records that should not be on_hold
@pkarman pkarman added bug-high-priority Product: caseflow-queue Eng: Data Mark when data has been backfilled, or the issue has any data integrity concerns Team: Echo 🐬 labels Nov 7, 2019
@lomky lomky added the Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. label Nov 8, 2019
@lowellrex
Copy link
Contributor

As of Tuesday this week (and this PR: #12576), opening a MailTask on a closed RootTask no longer changes the status of that RootTask.

@jimruggiero jimruggiero removed the Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. label Nov 26, 2019
@lomky
Copy link
Contributor

lomky commented Nov 26, 2019

Making it so the last task other than root task closing also closes the root task has some difficulty.

If we close the root task right now it implies the appeal is dispatched.
If we cancel the root task it implies the appeal was withdrawn.

Until we un-link the status of the appeal from the status of the root task, we are hesitant to make any other task status changes affect the state of the root task.

@lomky
Copy link
Contributor

lomky commented Nov 26, 2019

Closing this in favor of a larger conversation about decoupling the appeal state & root task state.

@lomky lomky closed this as completed Nov 26, 2019
@pkarman
Copy link
Contributor Author

pkarman commented Nov 26, 2019

see #12713

@alisan16 alisan16 added the Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Eng: Data Mark when data has been backfilled, or the issue has any data integrity concerns Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alisan16 @pkarman @lomky @lowellrex @jimruggiero