Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pull all user tasks after creating or updating a task #14290

Closed
4 tasks
hschallhorn opened this issue May 14, 2020 · 1 comment
Closed
4 tasks

Do not pull all user tasks after creating or updating a task #14290

hschallhorn opened this issue May 14, 2020 · 1 comment
Labels
Eng: Performance Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature

Comments

@hschallhorn
Copy link
Contributor

hschallhorn commented May 14, 2020

Some work around speeding up user queues was done in #14142 by paginating the initial loading of user tasks. This keeps us from calling QueueForRole, which pulls and serializes every task assigned to, completed by, and sometimes assigned by a user. We call QueueForRole after creating and updating a task as well, resulting in the whole user's queue returned to the front end when only a few tasks were updated or created.

AC

  • When creating a task, only return the created and updated tasks to the front end (any parents that have changed status or children that were created)
  • After creating a task, the front end reflects all created and updated tasks (tasks with changed status are moved to the correct queue tab without refresh, etc)
  • When updating a task, only return updated tasks to the front end (any parents that have changed status or children that were created)
  • After updating a task, the front end reflects all updated tasks (tasks with changed status are moved to the correct queue tab without refresh, etc)
@hschallhorn hschallhorn added Team: Echo 🐬 Eng: Performance Feature: generic-queue Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Type: Enhancement Enhancement to an existing feature Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels May 14, 2020
@lomky
Copy link
Contributor

lomky commented May 14, 2020

what is this chart?

1 | 
2 | 
3 | ||||||
5 | ||||||
8 | 

Judge Assign page can be used as an exemplar.
Definitely break up into multiple PRs.

Why 3?

  • sounds like we may need to write a new call?

Why 5?

  • A lot of task actions and tests to revise
  • Tracking down all places where tasks are created and changed to make sure the resulting state is correct after receiving tasks back will be a lengthy process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng: Performance Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants