Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve names for 3 task actions-related functions #9055

Closed
1 task
lowellrex opened this issue Jan 30, 2019 · 1 comment
Closed
1 task

Improve names for 3 task actions-related functions #9055

lowellrex opened this issue Jan 30, 2019 · 1 comment

Comments

@lowellrex
Copy link
Contributor

With the completion of PR #9014 we now have 3 functions related to task-action availability on the Task model named actions_allowable?, actions_available?, and available_actions. It is not immediately clear at a glance how those are different and what they do. This ticket exists to clarify those functions' purpose by (at a minimum) renaming them to be clearer. If during the process of the renaming we discover that there should be an accompanying refactor, we'll consider that as well.

Acceptance criteria

  • Names for these 3 functions more clearly communicate their... function
@hschallhorn
Copy link
Contributor

1 | ||||
2 | |||||||
3 | |
5 | 
8 |

Could be a larger ticket as these three functions appear in a lot of files. Coming to a consensus on the naming may prove to be a bigger lift than a simple find and replace. Renaming may create a refactor. After a very fruitful discussion on the reasoning behind higher estimations, votes were change to address these concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants