Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: remove all opt-out unit test failure #1636

Open
2 tasks
kalbfled opened this issue Feb 6, 2024 · 0 comments
Open
2 tasks

BUG: remove all opt-out unit test failure #1636

kalbfled opened this issue Feb 6, 2024 · 0 comments

Comments

@kalbfled
Copy link
Member

kalbfled commented Feb 6, 2024

Description

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

tests/lambda_functions/va_profile/test_va_profile_remove_old_opt_outs.py::test_remove_opted_out_records_query contains this snippet:

# TODO 1636 - This should not be commented out.
# assert notify_db_session.session.get(VAProfileLocalCache, opt_out_id) is None

The test should pass even when this is not commented out. Of the two parametrized cases, only "lambda_handler" fails. The other case uses SQLAlchemy to run a stored procedure and directly commits the change. The lambda handler case uses the lambda implementation, which uses psycopg2 to execute and commit the query.

The remove old opt-outs functionality seemed to work when we manually tested it, but it isn't being used. The first step for this ticket is to ensure the query works in AWS.

Steps to Reproduce

  1. Uncomment, and run the unit test.

Impact/Urgency

Expected Behavior

  • The unit test passes without commenting out the assertion.

Additional Info & Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant