BUG: NotNullViolation in nightly notification status

[cris-oddball]

Description

While working on SAWarnings in #1132, a pre-existing but unnoticed bug was found in app/celery/reporting_tasks.py::create_nightly_notification_status for the nightly stats query.

The logs report
psycopg2.errors.NotNullViolation: null value in column "notification_count" of relation "ft_notification_status" violates not-null constraint whenever the nightly process runs.

• Ticket is understood, and QA has been contacted (if the ticket has a QA label).

Steps to Reproduce

1. Observe the Cloudwatch logs for any environment within an hour of midnight ET to see the following when the nightly process runs:

Impact/Urgency

Unknown

Expected Behavior

• The Cloudwatch logs do not report a NotNullViolation when the nightly notification status runs

QA Considerations

• verify this is not seen when deployed to Perf/Staging

Additional Info & Resources

This does not need to wait until night time. The cron can be adjusted to run shortly after a deploy.

app/dao/fact_notification_status_dao.py L88

We have seen multiple iterations of this failure. For notification_count, It's not in the parameter list. Suspect it's being stripped out somewhere.

For bst_date it appears the whole row was null

[mjones-oddball]

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @k-macmillan @kalbfled @ldraney @MackHalliday @mchlwellman