Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery Status Callback Enhancement: VA Profile lookup failures #1800

Open
2 tasks
mjones-oddball opened this issue May 7, 2024 · 2 comments
Open
2 tasks

Comments

@mjones-oddball
Copy link

mjones-oddball commented May 7, 2024

User Story - Business Need

We want to ensure all critical points of failures are shared via delivery status callbacks with our clients, so they are empowered to analyze and manage their notifications. Recently, we discovered that contact info lookup errors were not triggering callbacks.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Business Line
I want to know if my notification fails due to a lookup error with VA Profile
So that I know which Veterans did not receive notifications as a result

Additional Info and Resources

  • Evan checked the prod logs and was able to see callbacks being triggered for an MPI lookup error, but did not see evidence of callback when contact information was not found in VA Profile. It's unclear how many other VA Profile related errors are or are not being sent through callback. Preference-declined is an example of one that is sent today.

Acceptance Criteria

  • Callbacks are triggered for VA Profile Lookup Errors

GIVEN callbacks are enabled for a service
WHEN a notification from that service enters a final error state due to a VA Profile contact or preference lookup failure
THEN a delivery status callback should be triggered to the appropriate destination assigned to that callback

QA Considerations

For QA to populate. Leave blank if QA is not applicable on this ticket.

  • Will need a vaprofiel id with no contact info (plenty in perf/staging to choose from, see kafka e2e testing to grab one)
  • Will need access to a callback
  • Work w/ dev on testing strategy
@mjones-oddball
Copy link
Author

@npmartin-oddball
Copy link

Surface concerns, and early, should they manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants