Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/7548-theo-ConfigureDynamicLinks #8006

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feature/7548-theo-ConfigureDynamicLinks #8006

merged 3 commits into from
Feb 21, 2024

Conversation

theodur
Copy link
Contributor

@theodur theodur commented Feb 16, 2024 •
edited
Loading

Description of Change

Configures Dynamic Link support for iOS and Android. The changes in this PR are:

  • Installing the @react-native-firebase/dynamic-links package
  • Updating AndroidManifest.xml to support vamobileapp.page.link links
  • Updating Info.plist and VAMobile.entitlements file to support vamobileapp.page.link links
  • Installing Dynamic link Pods

Screenshots/Video

N/A

Testing

  • Verified that clicking the link on iOS when the app is installed opens the app

  • Verified that First open and Re-opens metrics are being logged

  • Tested on iOS

  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@theodur theodur marked this pull request as ready for review February 19, 2024 19:03
@theodur theodur requested review from a team as code owners February 19, 2024 19:03
@theodur theodur added the FE-Needs Review Still waiting for PR Reviewers label Feb 19, 2024
@Sparowhawk Sparowhawk added FE-With QA A PR waiting for QA Activity and removed FE-Needs Review Still waiting for PR Reviewers labels Feb 20, 2024
@theodur theodur mentioned this pull request Feb 20, 2024
Closed
4 tasks
@theodur theodur merged commit 7606467 into develop Feb 21, 2024
11 checks passed
@theodur theodur deleted the feature/7548-theo-ConfigureDynamicLinks branch February 21, 2024 00:30
@timwright12 timwright12 restored the feature/7548-theo-ConfigureDynamicLinks branch February 22, 2024 20:33
@theodur theodur mentioned this pull request Mar 4, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sparowhawk Sparowhawk Sparowhawk approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees

@dumathane dumathane

@cadibemma cadibemma

Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theodur @Sparowhawk @dumathane @cadibemma