Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ability to link to unpublished Drupal pages with a node ID #17872

Closed
2 tasks
Tracked by #17926
RLHecht opened this issue Apr 16, 2024 · 7 comments · Fixed by #18034
Closed
2 tasks
Tracked by #17926

Fix the ability to link to unpublished Drupal pages with a node ID #17872

RLHecht opened this issue Apr 16, 2024 · 7 comments · Fixed by #18034
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area Needs refining Issue status

Comments

@RLHecht
Copy link
Collaborator

RLHecht commented Apr 16, 2024

User Story or Problem Statement

As a content author building out new Drupal pages, I need to be able to link to these pages easily using node IDs from within Drupal.

Drupal no longer allows an editor to link with a node ID to an unpublished page by typing in the H1 of the page.

Description or Additional Context

When creating a link within Drupal, the CMS used to allow you to type in the H1 of an unpublished page and it would pull up the node ID. Now if you start typing the H1 of an unpublished page, Drupal can't find it. In order to set up a link you need to manually add the node ID by typing /node/[nodeID] in the link field. Not sure why or when Drupal lost this functionality but it's much easier for an editor to find the node by typing the H1.
Note that the old way of adding a node ID still works with published pages.

Acceptance Criteria

  • Tech discovery on this regression is completed and issue is understood.
  • A path forward for a fix is identified
@RLHecht RLHecht added the Needs refining Issue status label Apr 16, 2024
@EWashb EWashb added CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area labels Apr 16, 2024
@EWashb
Copy link
Contributor

EWashb commented Apr 16, 2024

@gracekretschmer-metrostar Randi H. found a regression in the CMS. This isn't on fire, but we should see about building in this tech debt to an upcoming sprint. This used to work so I'm assuming a regression happened at some point in the last month or so

@gracekretschmer-metrostar

@keisterj-oddball to be added to do some discovery work to understand how this originally happened and how it was discovered.

@anantais
Copy link
Contributor

@RLHecht - do you know when you first noticed this issue (approximately)? I have tried a lot of things to fix this with nothing working yet. Right now, I am trying to figure out if this was an issue before the Drupal 10 upgrade or after.

@RLHecht
Copy link
Collaborator Author

RLHecht commented May 1, 2024

@anantais I would say for a few months. I asked a few other people on our team and they said the same. We noticed it after the node finder changed appearance, which I think was a Drupal 10 change so it probably started after. But that's just our hunch!

@anantais
Copy link
Contributor

anantais commented May 1, 2024

Update:

The problem seems to be with Linkit but so far I have not found anything obviously wrong. There is a checkbox in Linkit config for showing unpublished nodes (and that is checked). I tried changing permissions, reverting to older modules and looking through recent updates. At this point I am wondering if another module is an issue so I will look a little further back in the history of our module updates.

@anantais anantais linked a pull request May 3, 2024 that will close this issue
23 tasks
@anantais
Copy link
Contributor

anantais commented May 3, 2024

This seems like it could be an issue related to the Drupal 10 upgrade. The patch I applied has been around for a while but was re-released for Drupal 10. It does not appear as though we were using a patch before then.

Here is the issue - https://www.drupal.org/project/linkit/issues/3049946

@keisterj-oddball

@gracekretschmer-metrostar

@anantais this has been completed, correct? I wanted to confirm before I closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area Needs refining Issue status
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants