Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forms DB] Add field on Drupal form content type to indicate there's a react component for a particular form #17962

Closed
2 tasks done
Tracked by #17970
FranECross opened this issue Apr 25, 2024 · 5 comments
Assignees
Labels
Content forms [CMS feature] Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew

Comments

@FranECross
Copy link

FranECross commented Apr 25, 2024

Description

Add an on/off checkbox field on Drupal content type to indicate there's a react component for a particular form.

From Eric Tilberg in this Slack thread:
The official name is Form Upload. I've been referring to the widget as the "form upload widget" and the front-end process itself has been the "form upload flow". (It sounds kind of ridiculous to call it the "form upload form", especially since on the vets-website side, we aren't using the normal scaffolding that we use for our simple forms).

Default is unchecked
Named: Form Upload
Machine name: TBD
Help text: TBD
Location on edit page: TBD
Initial value: Empty

User story

AS AN engineer working on the Form Upload feature
I WANT a field in Drupal that will indicate if there is a react component for a particular form
SO THAT I can present the Veteran, their caregiver, family member or survivor with the Form Upload feature

Acceptance criteria

@FranECross
Copy link
Author

Noting Slack status offered to Erick in this thread in response to his question.

@dsasser
Copy link
Contributor

dsasser commented May 8, 2024

Location on edit page: TBD

@FranECross did we get an update on the location of this field on the VA Form form?

@FranECross
Copy link
Author

Ohhh, thanks for the reminder, @dsasser ! I snoozed on that question and will ask now. Stay tuned!

@dsasser
Copy link
Contributor

dsasser commented May 13, 2024

Update 5/13/24

The PR is pending approval.
FE graphql change has been communicated to Eric and his PR has been updated accordingly.

Once we get this merged, we'll need to wait for the CMS to release before Eric's PR will pass tests. Once tests pass there, Eric will finally be able to merge in his changes to content-build.

@dsasser
Copy link
Contributor

dsasser commented May 15, 2024

Verified on prod:

Screenshot 2024-05-15 at 10 31 54 AM

@dsasser dsasser closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content forms [CMS feature] Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew
Projects
None yet
Development

No branches or pull requests

2 participants