QA test plan & testing of injected header flattening / header-footer

[jilladams]

Testing context

Implementation ticket being tested: #17291
Who wrote the changes: @randimays

Where can testing be performed

• Local. WHY: Review Instances don't work. We can't figure out why.
• Review instance on a PR
• Tugboat. WHY:
• Staging behind a flipper. WHY:

Scope of changes: high level

In #17291, Randi has made the following changes:

• Used browser-rendered HTML as a starting to replace React code with basic HTML wherever possible, in both the header & footer
  • on VA.gov
  • in Injected header

Everything from the header and footer that can be clicked should be checked.

Affected components / what changed / what is new and should be tested

• Updated HTML for both VA.gov & Injected header
  • Header: Veterans Crisis line modal: updated HTML
  • Header: Search bar - flattened
  • Header: Megamenu, including behaviors like menu expansion, promo blocks appearing within right side of megamenu
  • Header & Footer: Markup for all links has been updated
  • Header: Govt header bar: " An official website of the United States government"
  • Footer: VA logo behavior
• Injected header: Login / Auth modal before logging in: under "Having trouble signing in?", fixed broken telephone web component
• Styling across breakpoints
• Cross-browser behavior: should check
  • Win/ Mac
  • Chrome, Safari, MS Edge
• a11y functionality
• Hover behavior

Only things that are still react are the Search bar and login modal

Gotchas / Exceptions

• Logging in doesn't work locally
• Megamenu Promo block images don't work locally. The dev branch is pulling from Staging, and these images are broken on Drupal staging as well.

Acceptance Criteria / Ownership

• @jv-agile6 Build a test plan in https://docs.google.com/spreadsheets/d/1JzJ8iso1Ji4_PQgTykZ2nl-FhGwZ9Pp1YrFfHMKG4uo/edit#gid=0. Including:
  • Prod behavior cases: https://va.gov
  • Prod behavior cases on an injected header site: https://www.va.gov/health
• Run test cases on a local build of Randi's [Injected (TeamSites) Header/Footer] Complete implementation of authentication code #17291 branch
  • Note failures in the spreadsheet and point to either a GH ticket or a Mural to demonstrate what you found
• @laflannery Requires accessibility review
• @thejordanwood Requires design review
• @chriskim2311 Code review
• Production UAT

[jilladams]

@FranECross we realized today in scrum that in the spirit of our recent QA conversations we need to be very deliberate about how we go about testing Randi's injected header changes, to make sure we don't break anything in prod. We're working up this ticket and will need to figure out how to cover the work in it (most of which may happen while you're out this week.)

[randimays]

The pull request for the code split is ready for review: department-of-veterans-affairs/vets-website#27590

As a reminder, the injected scenario can only be tested when running locally. But we also want to verify that no regressions were introduced to the VA.gov header/footer. This can be checked on the review instance in the PR.

[randimays]

Megamenu Promo block images don't work locally. The dev branch is pulling from Staging, and these images are broken on Drupal staging as well.

I was able to get the promo block images to show up after some metaphorical tree shaking on content-build (maybe cached Drupal assets?). It may be a toss-up whether it works for other folks, but the promo block info is in my screenshots in the PR description.

[jilladams]

@jv-agile6 is completing test plan for mobile steps & what injected does on prod vs. VA.gov
@chriskim2311 will run the test cases for injection locally
@laflannery / @thejordanwood will divide the modernized testing on RI

[laflannery]

I have completed my testing, all my notes are in the test plan doc and related mural. Let me know if anything needs further clarifcation

[thejordanwood]

I've also completed testing and added my notes to the spreadsheet and Mural.

[chriskim2311]

Completed testing and updated spreadsheet and added a few cards to the mural.

[randimays]

Update: I've addressed most of the feedback, but this one requires significant rework:

Unfortunately we'll have to go through the spreadsheet for testing again as I'll be changing most of the code.

[jilladams]

Mid-sprint: testing will repeat, timing to close for end of sprint will depend on re-verification.

[jilladams]

Thread with more details on the rework / plan of record: https://dsva.slack.com/archives/C03LFSPGV16/p1720028486617809