Fix sending email on Tugboat and Lando

[ndouglas]

Description

See this Slack thread.

As a developer, it'd be nifty if I could send email so I could verify that mail can be sent.

Email does not appear to be working on Tugboat or Lando, but does work on BRD.

Email can be sent (and is captured appropriately) from the command line through PHP:

drush eval 'mail("nathan.douglas@agile6.com", "drush eval", "");'

and from calling Drupal services directly:

drush eval '\Drupal::service("plugin.manager.mail")->mail("nug_doug", "nug_doug_key", "nathan.douglas@agile6.com", "en", ["message" => "", "title" => "service"], NULL, TRUE);'

But there seems to be a breakdown at some point that prevents email from being sent for e.g. password-reset requests. This should be identified and solved.

Acceptance Criteria

• Email can be sent (and is captured by Mailhog) when we attempt to send email through Drupal from Lando.
• Email can be sent (and is captured by Tugboat) when we attempt to send email through Drupal from Tugboat environments.

CMS Team

• Core Application Team
• Product Support Team

[ndouglas]

hmm

[ndouglas]

whee, so:

From _user_mail_notify() in user.module:

That's gonna fail if the user doesn't have an email address associated with their account. As mine doesn't.

I injected the following code in Drupal\Core\Mail\Plugin\Mail\PhpMail::mail(), right before \mail()` is called:

      \Drupal::logger('lol')->error(json_encode([
        'to' => $message['to'],
        'subject' => $mail_subject,
        'body' => $mail_body,
        'headers' => $mail_headers,
        'additional_headers' => $additional_headers,
      ], JSON_PRETTY_PRINT));

Before setting an email address on my account:

After setting an email address on my account:

I'd recommend that we write a script to update all users to set their email address equal to their account name, if it's not already set and the account name is a valid email address, and check to make sure we always set the email address specifically.

EDIT: It looks as though this might be triggered by the sanitization process performed on the DB as part of the sync to lower environments.

EDIT 2: Or this step where we do it explicitly.

TL;DR: If you want to test email on a lower environment, it should work once you set the account email explicitly. Also, don't expect Drupal or PHP to throw any errors because of the lack of a 'To' address. They won't.

[ndouglas]

Gonna close this as invalid; @acrollet @ElijahLynn thoughts on where I might document this? I was thinking about adding a README for gotchas/troubleshooting the local/tugboat dev process.

[acrollet]

Gonna close this as invalid; @acrollet @ElijahLynn thoughts on where I might document this? I was thinking about adding a README for gotchas/troubleshooting the local/tugboat dev process.

@ndouglas what if we add a line on the existing local and tugboat readmes? IMO we already have so many READMEs that it's hard to know what's where...

[ndouglas]

Yeah, I think you're right.