Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for commitizen modules #119

Closed
LinusU opened this issue Mar 21, 2016 · 6 comments
Closed

Support for commitizen modules #119

LinusU opened this issue Mar 21, 2016 · 6 comments

Comments

@LinusU
Copy link
Member

LinusU commented Mar 21, 2016

Commitizen is a tool for enforcing style of git commit messages, it's quite useful. However, npm-check is giving me a hard time about unused dependencies.

test-cz       馃槙  NOTUSED?  Possibly never referenced in the code.
                            npm uninstall --save-dev test-cz to remove.

My package.json looks like this:

{
  "devDependencies": {
    "test-cz": "^0.1.0"
  },
  "config": {
    "commitizen": {
      "path": "./node_modules/test-cz"
    }
  }
@LinusU
Copy link
Member Author

LinusU commented Mar 21, 2016

btw. I don't know why commitizen thought it was a good idea to use ./node_modules/test-cz instead of just test-cz (it internally uses require.resolve so both should work) but that is how it does when running commitizen init test-tz --save-dev...

@lijunle
Copy link
Member

lijunle commented Mar 21, 2016

It looks an excellent tool. Do you want to help to support it?

BTW, both ./node_modules/test-cz and test-cz are OK. We can use the same logic to resolve the path.

@lijunle lijunle added this to the 0.6.2 milestone Mar 21, 2016
@jimthedev
Copy link

Commitizen author here. @LinusU you can use either syntax in commitizen too. :) We need to update that in the docs, it is a historical artifact but was fixed recently in a PR that made it possible to use either. The main reason we offer it is if you want to write a custom adapter then we want you to be able to just point to a path. <3

@LinusU
Copy link
Member Author

LinusU commented Mar 24, 2016

@lijunle I have this bookmarked and I would love to send a pr, I can't give any guarantees on when though but hopefully I'll get some time this weekend.

@jimthedev Cool, let's support both here as well. As a side note, would it be possible to update commitizen init to put in test-cz instead of ./node_modules/test-cz? I think it looks cleaner...

@LinusU
Copy link
Member Author

LinusU commented Mar 24, 2016

Pull request submitted 馃檶

@lijunle
Copy link
Member

lijunle commented Mar 25, 2016

Resolved by #122, thanks to @LinusU :D

@lijunle lijunle closed this as completed Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants