Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False unused alert for webpack-and babel plugins #143

Closed
Zerim opened this issue Jun 8, 2016 · 9 comments
Closed

False unused alert for webpack-and babel plugins #143

Zerim opened this issue Jun 8, 2016 · 9 comments
Labels
Milestone

Comments

@Zerim
Copy link

Zerim commented Jun 8, 2016

Thanks for the great module! (Saved me a lot of time this morning). Adding a few issues to your list of false alerts.

This issue refers to plugin based modules. Specifically in the repo I'm working with, modules that follow the babel-* or *-loader naming convention, which are loaded automatically and crucial to the build process even if they are not required/imported.

@lijunle
Copy link
Member

lijunle commented Jun 19, 2016

Hi @Zerim , glad to hear this tool is helping you.

  1. How do you use the babel plugins? This tool will detect the plugins listed in .babelrc file.
  2. For the webpack loader. They must be list in webpack.config.js file. The filename is critical.

How is your case? Could you please provide more details?

@Zerim
Copy link
Author

Zerim commented Jun 26, 2016

Ah I think the naming is the issue then. Our webpack config files are called webpack.development.config.js and webpack.production.config.js ... I think this pattern is not uncommon for webpack setups. Not sure what the best solution is, maybe to allow us to specify this as a comand-line agument.

@cnolimit
Copy link

cnolimit commented Nov 7, 2016

@lijunle have the suggestions made by @Zerim been implemented? or is there an alternative way to removing them from the output and avoiding the strict naming convention?

@Zerim Zerim added feature and removed discussion labels Nov 7, 2016
@lijunle
Copy link
Member

lijunle commented Nov 7, 2016

I am fine to change the name check in this line. Do we have some naming convention here? /webpack\..*\.config.js/?

@lijunle
Copy link
Member

lijunle commented Nov 29, 2016

I published version 0.6.6 to support webpack config name with regex /webpack(\..+)?\.config.js/. Please test it and give feedbacks. Again, thank you for reporting this. 👍

@lijunle lijunle added this to the 0.6.6 milestone Nov 29, 2016
@wesleymostien
Copy link

my webpack config is in "webpack.config.js" file on the root but I still have alerts.
using : npm-check --specials bin,webpack

@mwt
Copy link

mwt commented Jun 23, 2019

I still have this same issue in the current version

@dcakirkaya
Copy link

Same issue, my webpack config file is called "webpack.config.js" and --specials=babel,bin,eslint,husky,jest,prettier,webpack
using depcheck 1.4.0

@joeyparis
Copy link

Can we have a way to specify the webpack config path? Mine is nested and follows a different path (e.g. internals/webpack/webpack.prod.babel.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants