Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depcheck should return a promise #146

Closed
vjpr opened this issue Jun 14, 2016 · 2 comments
Closed

Depcheck should return a promise #146

vjpr opened this issue Jun 14, 2016 · 2 comments
Labels
discussion

Comments

@vjpr
Copy link

vjpr commented Jun 14, 2016

Depcheck appears to use promises internally, but then only provides user with a callback.
@lijunle
Copy link
Member

lijunle commented Jun 14, 2016

We are returning a promise! We should document it...

@vjpr
Copy link
Author

vjpr commented Jun 14, 2016

Ah yep, missed that return. Docs would be good.

@vjpr vjpr closed this as completed Jun 14, 2016
@callumlocke callumlocke mentioned this issue Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vjpr @lijunle