Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when requiring files from modules directly: #147

Closed
SimonSchick opened this issue Jun 16, 2016 · 3 comments
Closed

False positive when requiring files from modules directly: #147

SimonSchick opened this issue Jun 16, 2016 · 3 comments

Comments

@SimonSchick
Copy link

SimonSchick commented Jun 16, 2016

Assume there is a module called @org/my-module installed but it's never required as require('@org/my-module') but instead only submodules are loaded such as require('@org/my-module/my-sub-module').
depcheck does not pick those up and instead flags them as unused.
This should be relatively easy to fix.

@lijunle
Copy link
Member

lijunle commented Jun 16, 2016

This should be handled. We are using require-package-name to handle this.

Could you please detail your case? Which package is reported? How is it be used?

@SimonSchick
Copy link
Author

The problem seems to be non deterministic.
It appears that it only shows these false positives every few runs.

@lijunle
Copy link
Member

lijunle commented Jun 19, 2016

@SimonSchick I looks strange, do you still get into this problem? Could you please provide more details about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants