Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scoped packages for special ESLint #174

Closed
goloroden opened this issue Nov 15, 2016 · 2 comments
Closed

Allow scoped packages for special ESLint #174

goloroden opened this issue Nov 15, 2016 · 2 comments

Comments

@goloroden
Copy link

In the special handler for ESLint there is currently an option disabled where it is about scoped packages (see this line of code).

I would like to do something about it, but I am note sure what to do.

Basically, you could just say, that any scoped package is fine here. This would be the easiest change. Do you have any special ideas for this?

Please let me know and I can prepare a PR.

@lijunle
Copy link
Member

lijunle commented Nov 15, 2016

Hi, @goloroden

Basically, the idea is to look at the inspired link mentioned in the comment 6 lines above your referenced code. I think ESLint has a big change on that function now: https://github.com/eslint/eslint/blob/master/lib/config/config-file.js#L461

Read and understand how ESLint handles the scoped package case, then copy the pattern here.

I do a rough review on the newest ESLint code, it looks point to this line. BTW, I saw ESLint is support some plugin:, that looks new feature after my implementation.

Again, thank you for helping this. If you have any questions, please comment.

@goloroden
Copy link
Author

Thanks for replying that fast :-)

I will have a look at this the day after tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants