Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when using vue-sticky in a vue component #238

Closed
Milad opened this issue Jan 27, 2018 · 4 comments
Closed

False positive when using vue-sticky in a vue component #238

Milad opened this issue Jan 27, 2018 · 4 comments

Comments

@Milad
Copy link
Contributor

Milad commented Jan 27, 2018

When importing vue-sticky to a Vue component, depcheck can't recognize its usage:

My Vue component

<template>
    <div v-sticky="{zIndex: 10000, stickyTop: 85}">
        <aside class="menu">
            <p class="menu-label">
                General
            </p>
        </aside>
    </div>
</template>

<script>
import VueSticky from 'vue-sticky';

export default {
    name: 'admin-menu',
    directives: {sticky: VueSticky}
};
</script>

depcheck --json output:

{
  "dependencies": [
    "vue-sticky"
  ]
}
@Milad Milad changed the title False dependency when using vue-sticky in a vue component False positive when using vue-sticky in a vue component Jan 27, 2018
@stale
Copy link

stale bot commented Nov 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 2, 2019
@rumpl
Copy link
Member

rumpl commented Nov 3, 2019

@Milad could you recheck with the latest depcheck please?

@stale stale bot removed the wontfix label Nov 3, 2019
@Milad
Copy link
Contributor Author

Milad commented Nov 8, 2019

I have checked this, and it seems to work fine in depcheck v0.9.0

@rumpl
Copy link
Member

rumpl commented Nov 8, 2019

Thank you @Milad I'll close this.

@rumpl rumpl closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants