Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depcheck error for workbox-build #290

Closed
peterennis opened this issue Sep 19, 2018 · 2 comments
Closed

depcheck error for workbox-build #290

peterennis opened this issue Sep 19, 2018 · 2 comments

Comments

@peterennis
Copy link

This result is false:

C:\ae\adaept.com>depcheck ae-svg-components
Unused devDependencies
* workbox-build

C:\ae\adaept.com>

This repo/commit: peterennis/ae-svg-components@279e536

workbox-build is required for npm run build --prod and the Stencil
build process will notify if it is missing.

@LinusU
Copy link
Member

LinusU commented Sep 19, 2018

Hmmm, shouldn't the Stencil package have a dependency on workbox-build? 🤔

@peterennis
Copy link
Author

Updated to latest Stencil

C:\ae\adaept.com\_components_>depcheck ae-svg-components
Unused devDependencies
* workbox-build

From here:
https://github.com/ionic-team/stencil/blob/master/package.json

  "lazyDependencies": {
    "@types/jest": "~23.3.1",
    "@types/puppeteer": "^1.6.4",
    "jest": "~23.6.0",
    "jest-cli": "~23.6.0",
    "pixelmatch": "4.0.2",
    "puppeteer": "~1.8.0",
    "workbox-build": "~3.4.1"
  },

When I use the "lazyDependencies" and fix the "devDependencies" I get:

C:\ae\adaept.com\_components_>depcheck ae-svg-components
No depcheck issue

So that looks like the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants