Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Alert with pre-commit module #320

Closed
segfaultdoc opened this issue Feb 14, 2019 · 3 comments
Closed

False Alert with pre-commit module #320

segfaultdoc opened this issue Feb 14, 2019 · 3 comments

Comments

@segfaultdoc
Copy link

  1. JSON: {
    "dependencies":[
    ],
    "devDependencies":[
    "pre-commit"
    ],
    "missing":{
    },
    "using":{
    "eslint-config-airbnb-base":[
    "/Users/zsherwani/my_projects/api.userservice/.eslintrc.yml"
    ],
    "eslint-plugin-import":[
    "/Users/zsherwani/my_projects/api.userservice/.eslintrc.yml"
    ],
    "eslint":[
    "/Users/zsherwani/my_projects/api.userservice/.eslintrc.yml",
    "/Users/zsherwani/my_projects/api.userservice/package.json"
    ],
    "express":[
    "/Users/zsherwani/my_projects/api.userservice/app.js",
    "/Users/zsherwani/my_projects/api.userservice/src/routes/customers.js",
    "/Users/zsherwani/my_projects/api.userservice/src/routes/jeffeUsers.js"
    ],
    "body-parser":[
    "/Users/zsherwani/my_projects/api.userservice/app.js"
    ],
    "aws-sdk":[
    "/Users/zsherwani/my_projects/api.userservice/app.js",
    "/Users/zsherwani/my_projects/api.userservice/src/database/Database.js",
    "/Users/zsherwani/my_projects/api.userservice/src/modules/Utilities.js"
    ],
    "depcheck":[
    "/Users/zsherwani/my_projects/api.userservice/package.json"
    ],
    "dotenv":[
    "/Users/zsherwani/my_projects/api.userservice/src/database/Database.js"
    ],
    "lodash":[
    "/Users/zsherwani/my_projects/api.userservice/src/middlewares/interceptors/UserInterceptor.js",
    "/Users/zsherwani/my_projects/api.userservice/src/middlewares/validators/TokenValidator.js",
    "/Users/zsherwani/my_projects/api.userservice/src/middlewares/validators/SchemaValidator.js"
    ],
    "jsonwebtoken":[
    "/Users/zsherwani/my_projects/api.userservice/src/middlewares/validators/TokenValidator.js",
    "/Users/zsherwani/my_projects/api.userservice/src/models/user.js"
    ],
    "joi":[
    "/Users/zsherwani/my_projects/api.userservice/src/middlewares/validators/SchemaValidator.js",
    "/Users/zsherwani/my_projects/api.userservice/src/schemas/customerSchema.js",
    "/Users/zsherwani/my_projects/api.userservice/src/schemas/jeffeSchema.js"
    ],
    "bcrypt":[
    "/Users/zsherwani/my_projects/api.userservice/src/models/user.js"
    ],
    "request":[
    "/Users/zsherwani/my_projects/api.userservice/test/test.js"
    ]
    },
    "invalidFiles":{
    },
    "invalidDirs":{
    }
    }

  2. The pre-commit devdependency is a false alert

  3. This package is a "pre-commit hook installer", it gets installed in the .git directory, seems as though this is being skipped over.

https://www.npmjs.com/package/pre-commit

@rumpl
Copy link
Member

rumpl commented Feb 14, 2019

Hey @segfaultdoc, thanks for reporting this, the pre-commit is reported as unused because it's not used in the code, we would need to do some special things in order to manage this package, for now you can use the --ignores flag so that it doesn't report it as unused.

Cheers

@stale
Copy link

stale bot commented Nov 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 2, 2019
@VincentLanglet
Copy link
Contributor

@rumpl Duplicate of #261

@stale stale bot removed the wontfix label Nov 3, 2019
@rumpl rumpl closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants