Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when only importing typescript interfaces (so no runtime code) from a package #359

Closed
Zjaaspoer opened this issue Jun 26, 2019 · 2 comments

Comments

@Zjaaspoer
Copy link

Bug Description

Only importing TypeScript interfaces (so no runtime code) provides false positives.

Versions

  • depcheck --version: 0.8.1

Extra info

It seems like the analysis is done on the compiled code and therefore won't know about the imported interfaces (as they are removed during compilation)?

@rumpl
Copy link
Member

rumpl commented Jun 26, 2019

Hey, thanks for reporting this, yes this is a known issue, the fix is to use the typescript parser and not babel for typescript files, will get to it as soon as I have some time.

I'll close this one since we already have a ticket for this #163

Cheers

@rumpl rumpl closed this as completed Jun 26, 2019
@Zjaaspoer
Copy link
Author

ah ok, thanks, will track that ticket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants