Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github dependencies not recursing? #410

Closed
christopherjbaker opened this issue Aug 13, 2019 · 1 comment
Closed

Github dependencies not recursing? #410

christopherjbaker opened this issue Aug 13, 2019 · 1 comment

Comments

@christopherjbaker
Copy link

Bug Description

I have installed a dependency from github, which in turn has installed its own dependencies. The problem is that all of those show up as Unused dependencies in depcheck. =[

Code snippets

This particular package is only used as a bin by executing a command inside else, never required, so I did have to add it to my ignores, but the others all still show up too.

Where the dependency is listed in package.json:

"dependencies": {
  "foo-cli": "github:foo/foo-cli",

Versions

  • node -v: v12.2.0
  • npm -v: v12.2.0
  • depcheck --version: 0.8.3

Extra info

I looked at this, though there is a fair amount of sanitization I would have to do to share. Neither the github dependency nor its dependencies appear in the using section. The dependecies section is just the list of false positives.

@christopherjbaker
Copy link
Author

Nevermind. I had installed a number of those packages because I was going to join them into a singel repo, then decided to keep them separate but didn't uninstall those packages. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant