Incorrect unused dependencies in react-ace

[dave-nm]

Bug Description

Run depcheck on the code for react-ace and it says that the following is unused even though they are used:

Unused dependencies
* diff-match-patch
* lodash.get
* lodash.isequal
* prop-types

Code snippets

Where the dependency is used:
https://github.com/securingsincity/react-ace

Where the dependency is listed in package.json:
dependencies

Versions

• node -v: v10.16.3
• npm -v: 6.9.0
• depcheck --version: 0.8.3

Extra info

Any extra info you want to include. Thank you for the bug report!

{"dependencies":["diff-match-patch","lodash.get","lodash.isequal","prop-types"],"devDependencies":["@babel/cli","@babel/preset-env","@babel/preset-react","@types/chai","@types/enzyme","@types/enzyme-adapter-react-16","@types/lodash","@types/mocha","@types/node","@types/prop-types","@types/react","@types/react-dom","@types/sinon","babel-loader","coveralls","eslint-plugin-import","eslint-plugin-jsx-a11y","husky","pretty-quick","react-test-renderer","ts-loader","tslint-react","webpack-cli"],"missing":{},"using":{"babel-eslint":["/Users/dlj/projects/react-ace/.eslintrc"],"eslint-plugin-react":["/Users/dlj/projects/react-ace/.eslintrc"],"eslint":["/Users/dlj/projects/react-ace/.eslintrc"],"react":["/Users/dlj/projects/react-ace/example/diff.js","/Users/dlj/projects/react-ace/example/split.js","/Users/dlj/projects/react-ace/example/index.js","/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"react-dom":["/Users/dlj/projects/react-ace/example/diff.js","/Users/dlj/projects/react-ace/example/split.js","/Users/dlj/projects/react-ace/example/index.js","/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"brace":["/Users/dlj/projects/react-ace/example/diff.js","/Users/dlj/projects/react-ace/example/split.js","/Users/dlj/projects/react-ace/example/index.js","/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"mocha":["/Users/dlj/projects/react-ace/package.json"],"nyc":["/Users/dlj/projects/react-ace/package.json"],"prettier":["/Users/dlj/projects/react-ace/package.json"],"rimraf":["/Users/dlj/projects/react-ace/package.json"],"ts-node":["/Users/dlj/projects/react-ace/package.json","/Users/dlj/projects/react-ace/package.json"],"tslint":["/Users/dlj/projects/react-ace/package.json","/Users/dlj/projects/react-ace/tslint.json"],"typescript":["/Users/dlj/projects/react-ace/package.json","/Users/dlj/projects/react-ace/package.json","/Users/dlj/projects/react-ace/tslint.json"],"webpack":["/Users/dlj/projects/react-ace/package.json","/Users/dlj/projects/react-ace/webpack.config.development.js","/Users/dlj/projects/react-ace/webpack.config.production.js","/Users/dlj/projects/react-ace/webpack.config.example.js"],"webpack-dev-server":["/Users/dlj/projects/react-ace/package.json"],"@babel/register":["/Users/dlj/projects/react-ace/package.json"],"@babel/core":["/Users/dlj/projects/react-ace/package.json"],"chai":["/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"sinon":["/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"enzyme":["/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"enzyme-adapter-react-16":["/Users/dlj/projects/react-ace/tests/src/ace.spec.js","/Users/dlj/projects/react-ace/tests/src/split.spec.js"],"jsdom":["/Users/dlj/projects/react-ace/tests/setup.js"]},"invalidFiles":{},"invalidDirs":{}}

[rumpl]

Hey @dave-nm, what version of depcheck are you using ?
I just cloned react-ace and ran depcheck on it and I get:

➜  react-ace git:(master) ✗ npx depcheck
Unused dependencies
* @babel/polyfill
Unused devDependencies
* @babel/cli
* @babel/core
* @babel/preset-env
* @babel/preset-react
* @babel/register
* @types/chai
* @types/enzyme
* @types/enzyme-adapter-react-16
* @types/lodash
* @types/mocha
* @types/node
* @types/prop-types
* @types/react
* @types/react-dom
* @types/sinon
* babel-loader
* coveralls
* eslint-plugin-import
* eslint-plugin-jsx-a11y
* husky
* pretty-quick
* react-test-renderer
* ts-loader
* tslint-react
* webpack-cli

[dave-nm]

I was running 0.8.1 but updated to 0.8.3 before submitting this bug and I still get the same output:

Unused dependencies
* diff-match-patch
* lodash.get
* lodash.isequal
* prop-types
Unused devDependencies
* @babel/cli
* @babel/preset-env
* @babel/preset-react
* @types/chai
* @types/enzyme
* @types/enzyme-adapter-react-16
* @types/lodash
* @types/mocha
* @types/node
* @types/prop-types
* @types/react
* @types/react-dom
* @types/sinon
* babel-loader
* coveralls
* eslint-plugin-import
* eslint-plugin-jsx-a11y
* husky
* pretty-quick
* react-test-renderer
* ts-loader
* tslint-react
* webpack-cli

[rumpl]

I cloned and did an npm install, and then did a simple npx depcheck.

If you don't mind, could you do the same and also add the output with --json?

Thanks!

[dave-nm]

The output with --json is in the original report

[rumpl]

Event with 0.8.3?

Hm...

Mistery

[dave-nm]

Yes, that output is with 0.8.3. I just did a complete reinstall of node (10.16.3) and npm (6.9.0) and then did npm install -g depcheck and I'm getting the same output.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[rumpl]

not stale

[daveisfera]

I just ran with the 0.9.0 release and I'm not longer seeing this issue

[rumpl]

Nice, thanks!