Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json shows up as a component - false positives in compliance #3461

Open
2 tasks done
black-snow opened this issue Feb 12, 2024 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@black-snow
Copy link

black-snow commented Feb 12, 2024

Current Behavior

Hi, I'm not sure yet whether this should be seen as a question, request or bug report.

I've noticed that DT lists package-lock.json as a component. It kind of makes sense when looking at the dependency tree, but otherwise it's not really a component of the app. It also does not have any license information and hence gets flagged as unresolved.

I don't know if the license would be picked up if I had any in my package.json, but if it did it would be a non-free license (company internal) and then show up as a false positive policy violation.

It might also just be an issue with trivy, which generated:

    {
      "bom-ref": "a5d557f0-e70a-41b8-98bc-7037e70ec009",
      "type": "application",
      "name": "package-lock.json",
      "properties": [
        {
          "name": "aquasecurity:trivy:Class",
          "value": "lang-pkgs"
        },
        {
          "name": "aquasecurity:trivy:Type",
          "value": "npm"
        }
      ]
    },

Proposed Behavior

I'm not sure if it should be a component at all. If so, shouldn't it have the name of my app instead of package-lock.json?

Given that it makes sense to have this at all - I'd need a way to tell DT that this is my component and that the license information of this very component is to be ignored (not its children, though).

It might suffice if in the policy editor I'd be able to add a condition like componentName != package-lock.json. But there currently doesn't seem to a way to use component names in conditions.

Checklist

@black-snow black-snow added the enhancement New feature or request label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant