Getting author name from from and project

[nandahkrishna]

Fix for issue #107 - getting the author name in generate license from from and project config files.

Please do review this and suggest changes as there may be errors. Thanks!

[nandahkrishna]

Ah well, guess there's some problem as the test fails. I'll check it.
Edit: There seems to be no key named 'from' in self.config which throws the error in test. I'm not exactly able to get a solution to this, though.

[orsinium]

Yeah, that's right. 'from' is missed if there is no project config. Do # get author from from only if 'from' in self.config :)

[orsinium]

You can do less operations if chain ways to get author:

author = self.config.get('owner')
if not author and 'from' in self.config:
  ...
if not author:
  authors = PackageRoot(self.config['project']).metainfo.authors
  if authors:
    author = authors[0]
if not author:
  author = getuser().title()

...

[nandahkrishna]

Yes, I'll get this done. Thanks!

[nandahkrishna]

The changes have been made with this commit.
Just one clarification though - if the project configuration file has > 1 author, we select only the first as author = authors[0]; however in getting the author from from, we have author = root.authors. Would this pose a problem or inconsistency?

Edit: Test fails because self.config['project'] is str and not Path, I'll change it.

[orsinium]

In "from" case we also have to get the first author. I'm not sure about licensing rules, but usually owner is only one person.

Everything looks really good. Fix this case and check what Travis says, and I'll merge it :)

[nandahkrishna]

Travis is showing an error in the test again, now with respect to the metainfo. It shows an IndexError when the metainfo is being accessed. I tried to search for a place where metainfo is obtained by this, but I could not find any (probably missed my eye).

Screenshot:

[orsinium]

Oh, my bad. I'll patch it

[orsinium]

Done. Thank you for your contribution :)