Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The writable_dirs task makes files also writable #49

Closed
Mihailoff opened this issue Aug 6, 2014 · 3 comments
Closed

The writable_dirs task makes files also writable #49

Mihailoff opened this issue Aug 6, 2014 · 3 comments
Milestone

Comments

@Mihailoff
Copy link
Contributor

https://github.com/elfet/deployer/blob/master/recipe/common.php#L138

I think there should be distinction like we have with shared_dirs / shared_files.

Probably more intelligent way is to get rid of such difference and have only one shared option witch will able to guess is given argument a file or a directory.

set('shared', ['app/logs/', 'app/config/parameters.yml']);
set('writable', ['app/logs/', 'app/logs/*', 'app/public/whatever']);

Slash at the end treated as directory, file otherwise. Asterisk explicitly says that it is recursive.

@antonmedv
Copy link
Member

Yes, it will be good. But a lot of users will write it without / on end. So we need to guess it on server.

@AlexStansfield
Copy link
Contributor

There is improved permissions on writable directories from PR #81

Perhaps this solves the main issue here.

@antonmedv antonmedv modified the milestone: Deployer 3 Nov 24, 2014
@antonmedv
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants