Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters with escaping for run command #52

Closed
Mihailoff opened this issue Aug 7, 2014 · 3 comments
Closed

Parameters with escaping for run command #52

Mihailoff opened this issue Aug 7, 2014 · 3 comments

Comments

@Mihailoff
Copy link
Contributor

One more enhancement ;)

runWithParameters('some.sh --param=? || anything_else ?', ['foo', 'zoo']);

Should be converted to

run('some.sh --param=`foo` || anything_else `zoo`');
@antonmedv
Copy link
Member

I think this is better:

run('some.sh --param=? || anything_else ?', ['foo', 'zoo']);

@Mihailoff
Copy link
Contributor Author

This was an initial idea and then I saw that run have different second argument...

https://github.com/elfet/deployer/blob/v1.1.2/src/functions.php#L78

Raw parameter seems little bit hacky, maybe move it to runRemotely?

At the end there might be run, runLocally and runRemotely and all of them could have parameters as second argument.

@antonmedv antonmedv removed the feature label Aug 13, 2014
@antonmedv
Copy link
Member

I'll fix it in Deployer 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants