Contributions are welcome and will be fully credited.
-
Document any change in behaviour - Make sure the
README.md
and any other relevant documentation are kept up-to-date. -
Create feature branches - Don't ask us to pull from your master branch.
-
One pull request per feature - If you want to do more than one thing, send multiple pull requests.
-
Send coherent history - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting.
-
We use Zenify Coding Standard
-
The easiest way to apply the conventions:
$ composer require zenify/coding-standard --dev
$ vendor/bin/phpcs src tests --extensions=php --ignore=bootstrap --standard=vendor/zenify/coding-standard/src/ZenifyCodingStandard/ruleset.xml
-
Add tests! - Your patch won't be accepted if it doesn't have tests.
-
Run tests by calling
phpunit
(requires having PHPUnit installed locally)
Both coding standard and tests are validated by Travis CI, so just make it pass.
Happy coding!