Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Newsletter Subscription Forms #68

Open
nring opened this issue May 18, 2022 · 0 comments
Open

Enhance Newsletter Subscription Forms #68

nring opened this issue May 18, 2022 · 0 comments

Comments

@nring
Copy link
Contributor

nring commented May 18, 2022

We have two places to sign up for the blog Newsletter.

  1. The "Subscribe" button in the header, which displays the subscription form in a modal
  2. The area beneath the content of a single post, which displays the subscription form right on the page.

The following should be done for both instances of the form:

  1. Add ::selection styling for text box so user can tell when their email address is highlighting
  2. Prevent submission of empty form
  3. Add basic email validation.
  4. Add error handling and display a generic message for most cases. "Oops! Something went wrong. Please refresh and try subscribing again."
  5. Make sure styling is handled for both the full-screen modal variation and footer variation

Notes:

  • Using input type="email" might allow us to solve for items 2 and 3. Ghost should (hopefully) doing server side validation of data sent on their side. If something isn't quite right with the submission and the we get a response error then let's display the generic error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant