New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only set allowedOrigin when needed #248
Conversation
$driver.get fixture "/index.html" | ||
run_axe | ||
allowed_origin = get_allowed_origin.first() | ||
expect(allowed_origin).to eq "http://localhost:8000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should be checking the get_allowed_origin.length
here as well? Axe-core does .push
and it might be forward-thinking to ensure that there is only one for this series of checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the examples we should just check the 0th array https://github.com/dequelabs/axe-test-fixtures/blob/v1/README.md?plain=1#L440
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to dismiss. I see why that's the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the .length
now that there isn't a .first
, but it LGTM as-is.
No description provided.