Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to use axe-core 4.5.2 #269

Merged
merged 3 commits into from Nov 15, 2022
Merged

fix: update to use axe-core 4.5.2 #269

merged 3 commits into from Nov 15, 2022

Conversation

michael-siek
Copy link
Member

<< Describe the changes >>

Closes issue: #<< ticket number >>

@michael-siek michael-siek requested a review from a team as a code owner November 15, 2022 13:54
package.json Outdated
Comment on lines 17 to 18
"dependencies": {
"axe-core": "^4.5.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update needs to occur within packages/axe-core-api

Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing - Forgot to remove axe-core dependency from the root

package.json Outdated
@@ -13,5 +13,8 @@
"devDependencies": {
"axe-test-fixtures": "github:dequelabs/axe-test-fixtures",
"standard-version": "^9.0.0"
},
"dependencies": {
"axe-core": "^4.5.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed its not used

@michael-siek michael-siek merged commit 6c1e542 into develop Nov 15, 2022
@michael-siek michael-siek deleted the fix/axe-core/4.5.2 branch November 15, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants