Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update axe-core to v3.3.1 #71

Merged
merged 2 commits into from Jul 29, 2019
Merged

feat: update axe-core to v3.3.1 #71

merged 2 commits into from Jul 29, 2019

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Jul 25, 2019 •
edited by WilcoFiers

Update axe-core to v3.3.1

Closes issue: NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested a review from WilcoFiers July 25, 2019 10:58
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jul 25, 2019 •
edited

Debug Notes: CI is breaking on testing some examples on cucumber/selenium, stating that __magic__ is not found, which goes back to this change - dequelabs/doT@0c52a99#diff-9e11a98811840f568e5be7003b9ea32fR38

@jeeyyy jeeyyy changed the title feat: update axe-core to v3.3.1 [WIP] feat: update axe-core to v3.3.1 Jul 29, 2019
@jeeyyy jeeyyy changed the title [WIP] feat: update axe-core to v3.3.1 feat: update axe-core to v3.3.1 Jul 29, 2019
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Jul 29, 2019

Fix to pass test (examples) on CI was to update version of Firefox and Geckodriver, which was handled in PR https://github.com/dequelabs/axe-matchers/pull/72

@jeeyyy jeeyyy merged commit bb347e5 into develop Jul 29, 2019
@jeeyyy jeeyyy deleted the update-axe-version branch July 29, 2019 13:36
@jeeyyy jeeyyy restored the update-axe-version branch July 29, 2019 13:36
@jeeyyy jeeyyy deleted the update-axe-version branch July 29, 2019 13:36
@jeeyyy jeeyyy mentioned this pull request Jul 29, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @WilcoFiers