feat(cli): better error message for ChromeDriver version mismatch #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
straker
requested changes
Mar 16, 2023
|
Hey @not-my-profile just reaching out to see if you've seen the request changes on the PR. |
not-my-profile
force-pushed
the
better-error-for-chromedriver-version-mismatch
branch
from
63c7d4e
to
d54a370
Compare
not-my-profile
force-pushed
the
better-error-for-chromedriver-version-mismatch
branch
from
d54a370
to
aefecb3
Compare
straker
previously requested changes
Jul 10, 2023
| $ npm install -g chromedriver@<version> | ||
| $ axe --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver <url...> | ||
|
|
||
| (where <version> is the first number of the "current browser version" reported above.)`); |
There was a problem hiding this comment.
"the first number" is a bit ambiguous. We should be very specific about what we want as browser version 114.0.5735.198 the first number would be 1 which would not be the version of chromedriver we want.
There was a problem hiding this comment.
You're confusing "digit" with "number". I changed your suggestion of "major version" to "first number of the version" since I think there's a good chance that the user isn't familiar with SemVer.
|
Hey @not-my-profile ! Just missing a test and I think this is good to go |
straker
approved these changes
Aug 22, 2023
|
Thanks for the contribution. Reviewed for security |
This was referenced Aug 24, 2023
Closed
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679.