feat(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgro…

…up rules (#1640) * fix(radiogroup, checkboxgroup): deprecate radiogroup and checkboxgroup rules * adding deprecated tag * rule descriptions
dequelabs · Jul 30, 2019 · 6d30880 · 6d30880
1 parent 8ab262a
commit 6d30880
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md
@@ -21,7 +21,7 @@
 | blink                               | Ensures &lt;blink&gt; elements are not used                                                                                | Serious            | cat.time-and-media, wcag2a, wcag222, section508, section508.22.j             | true               |
 | button-name                         | Ensures buttons have discernible text                                                                                      | Critical           | cat.name-role-value, wcag2a, wcag412, section508, section508.22.a            | true               |
 | bypass                              | Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content              | Serious            | cat.keyboard, wcag2a, wcag241, section508, section508.22.o                   | true               |
-| checkboxgroup                       | Ensures related &lt;input type=&quot;checkbox&quot;&gt; elements have a group and that the group designation is consistent | Critical           | cat.forms, best-practice                                                     | true               |
+| checkboxgroup                       | Ensures related &lt;input type=&quot;checkbox&quot;&gt; elements have a group and that the group designation is consistent | Critical           | cat.forms, best-practice, deprecated                                         | false              |
 | color-contrast                      | Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds                    | Serious            | cat.color, wcag2aa, wcag143                                                  | true               |
 | css-orientation-lock                | Ensures content is not locked to any specific display orientation, and the content is operable in all display orientations | Serious            | cat.structure, wcag134, wcag21aa, experimental                               | true               |
 | definition-list                     | Ensures &lt;dl&gt; elements are structured correctly                                                                       | Serious            | cat.structure, wcag2a, wcag131                                               | true               |
@@ -68,7 +68,7 @@
 | object-alt                          | Ensures &lt;object&gt; elements have alternate text                                                                        | Serious            | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a          | true               |
 | p-as-heading                        | Ensure p elements are not used to style headings                                                                           | Serious            | cat.semantics, wcag2a, wcag131, experimental                                 | true               |
 | page-has-heading-one                | Ensure that the page, or at least one of its frames contains a level-one heading                                           | Moderate           | cat.semantics, best-practice                                                 | true               |
-| radiogroup                          | Ensures related &lt;input type=&quot;radio&quot;&gt; elements have a group and that the group designation is consistent    | Critical           | cat.forms, best-practice                                                     | true               |
+| radiogroup                          | Ensures related &lt;input type=&quot;radio&quot;&gt; elements have a group and that the group designation is consistent    | Critical           | cat.forms, best-practice, deprecated                                         | false              |
 | region                              | Ensures all page content is contained by landmarks                                                                         | Moderate           | cat.keyboard, best-practice                                                  | true               |
 | role-img-alt                        | Ensures [role=&apos;img&apos;] elements have alternate text                                                                | Serious            | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a          | true               |
 | scope-attr-valid                    | Ensures the scope attribute is used correctly on tables                                                                    | Moderate, Critical | cat.tables, best-practice                                                    | true               |

diff --git a/lib/rules/checkboxgroup.json b/lib/rules/checkboxgroup.json
@@ -1,11 +1,12 @@
 {
 	"id": "checkboxgroup",
 	"selector": "input[type=checkbox][name]",
-	"tags": ["cat.forms", "best-practice"],
+	"tags": ["cat.forms", "best-practice", "deprecated"],
 	"metadata": {
 		"description": "Ensures related <input type=\"checkbox\"> elements have a group and that the group designation is consistent",
 		"help": "Checkbox inputs with the same name attribute value must be part of a group"
 	},
+	"enabled": false,
 	"all": [],
 	"any": ["group-labelledby", "fieldset"],
 	"none": []

diff --git a/lib/rules/radiogroup.json b/lib/rules/radiogroup.json
@@ -1,11 +1,12 @@
 {
 	"id": "radiogroup",
 	"selector": "input[type=radio][name]",
-	"tags": ["cat.forms", "best-practice"],
+	"tags": ["cat.forms", "best-practice", "deprecated"],
 	"metadata": {
 		"description": "Ensures related <input type=\"radio\"> elements have a group and that the group designation is consistent",
 		"help": "Radio inputs with the same name attribute value must be part of a group"
 	},
+	"enabled": false,
 	"all": [],
 	"any": ["group-labelledby", "fieldset"],
 	"none": []