Skip to content

Commit

Permalink
fix(rules): Allow focusable role=application elements
Browse files Browse the repository at this point in the history
  • Loading branch information
WilcoFiers committed May 13, 2018
1 parent 5644b95 commit b5de450
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/checks/aria/valid-scrollable-semantics.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const VALID_TAG_NAMES_FOR_SCROLLABLE_REGIONS = {
* appropriate for scrollable elements found in the focus order.
*/
const VALID_ROLES_FOR_SCROLLABLE_REGIONS = {
application: true,
banner: false,
complementary: true,
contentinfo: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ <h4>Valid landmark roles for scrollable containers</h4>
<div id="pass5" role="contentinfo" tabindex="0"></div>
<div id="pass6" role="main" tabindex="0"></div>
<div id="pass7" role="region" tabindex="0"></div>
<div id="pass8" role="application" tabindex="0"></div>
</div>
<h4>Valid scrollable HTML tags for scrollable regions, not selected by this rule</h4>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
["#pass4"],
["#pass5"],
["#pass6"],
["#pass7"]
["#pass7"],
["#pass8"]
],
"violations": [
["#violation1"],
Expand Down

0 comments on commit b5de450

Please sign in to comment.