Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Div disallowed as immediate child of <dl> #1201

Closed
studiobl opened this issue Oct 24, 2018 · 1 comment
Closed

Div disallowed as immediate child of <dl> #1201

studiobl opened this issue Oct 24, 2018 · 1 comment

Comments

@studiobl
Copy link

studiobl commented Oct 24, 2018

The w3 HTML5 spec allows a div to be the immediate child of a dl, then a dd or dt to be a child of that div, but the Attest Chrome browser extension calls out an error: "

elements must only directly contain properly-ordered
and
groups, <script> or elements"

https://www.w3.org/TR/html5/grouping-content.html#the-dl-element

Here's the list that Attest called out:

<dl data-qa-id="account-summary">
    <div class="_3S--zFMxqz" data-qa-id="definition-item-account-summary-0">
        <dt class="_1kW0j6OaMX">Name</dt>
        <dd class="DyjTKZHqTQ">Ms Joanna Smith, Dr.</dd>
    </div>
    <div class="_3S--zFMxqz" data-qa-id="definition-item-account-summary-1">
        <dt class="_1kW0j6OaMX">Account ID</dt>
        <dd class="DyjTKZHqTQ">00000012345</dd>
    </div>
    <div class="_3S--zFMxqz" data-qa-id="definition-item-account-summary-2">
        <dt class="_1kW0j6OaMX">Broken promises to pay - current year</dt>
        <dd class="DyjTKZHqTQ">0</dd>
    </div>
    <div class="_3S--zFMxqz" data-qa-id="definition-item-account-summary-3">
        <dt class="_1kW0j6OaMX">Broken promises to pay - previous year</dt>
        <dd class="DyjTKZHqTQ">2</dd>
    </div>
    <div class="_3S--zFMxqz" data-qa-id="definition-item-account-summary-4">
        <dt class="_1kW0j6OaMX">Next payment due</dt>
        <dd class="DyjTKZHqTQ">05/08/2017</dd>
    </div>
</dl>
@marcysutton
Copy link
Contributor

Thanks for your issue. This should already be handled by the code in #1076, I think it just needs to be released. Going to close as a duplicate of #262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants