Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow role presentation and none on object-alt rule #1224

Merged
merged 2 commits into from Nov 7, 2018
Merged

fix: Allow role presentation and none on object-alt rule #1224

merged 2 commits into from Nov 7, 2018

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Nov 6, 2018 •
edited by WilcoFiers

This PR, allows role presentation/ none on object.

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested a review from a team as a code owner November 6, 2018 11:52
@jeeyyy jeeyyy changed the title fix: allow role presentation and none on object fix: allow role presentation and none on object-alt Nov 6, 2018
@jeeyyy jeeyyy changed the title fix: allow role presentation and none on object-alt fix: allow role presentation and none on object-alt rule Nov 6, 2018
@WilcoFiers WilcoFiers changed the title fix: allow role presentation and none on object-alt rule fix: Allow role presentation and none on object-alt rule Nov 7, 2018
@WilcoFiers WilcoFiers merged commit d475a17 into develop Nov 7, 2018
@WilcoFiers WilcoFiers deleted the object-alt-fix branch November 7, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @WilcoFiers