Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding WCAG tags with dots "wcag4.1.2" instead of "wcag412" #1309

Closed
WilcoFiers opened this issue Jan 9, 2019 · 4 comments
Closed
Labels
feat New feature or enhancement needs discussion More discussion is needed to continue wcag 2.1
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jan 9, 2019

Add duplicate labels that have dots as separators to ensure that this is a non-breaking change

@WilcoFiers WilcoFiers added feat New feature or enhancement needs discussion More discussion is needed to continue wcag 2.1 labels Jan 16, 2019
@straker
Copy link
Contributor

straker commented Oct 11, 2019

A simple but tedious change. Just need to go through each rule metadata file and add a matching WCAG tag with dot separated numbers to each rule's tag array.

@straker straker added hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ and removed needs discussion More discussion is needed to continue labels Oct 11, 2019
@jeeyyy
Copy link
Contributor

jeeyyy commented Oct 16, 2019

PR merged. Closing issue.

@jeeyyy jeeyyy closed this as completed Oct 16, 2019
@jeeyyy jeeyyy reopened this Oct 16, 2019
@chandana7393
Copy link

chandana7393 commented Oct 17, 2019

Tested, one checkpoint is appearing twice one with decimal points and other without them in the Issue tags of the extension.
axe-coconut_wcag

CC: @somaalapati
Tested Environment:
Axe-coconut - 4.0.0.29004v
Chrome - 77.0.3865.120v
OS - Windows 10 64 bit.

@straker straker added needs discussion More discussion is needed to continue and removed hacktoberfest Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/ labels Oct 18, 2019
@straker straker added this to the Axe-core 4.0 milestone Nov 25, 2019
@jeeyyy jeeyyy removed their assignment Jan 21, 2020
@WilcoFiers
Copy link
Contributor Author

Closing this issue. This is unlikely to ever be necessary. The most likely SC where this could become ambiguous is if a 2.11.1 and a 2.1.11 ever get released. This is unlikely, as Principle 2 only has 5 guidelines (we would nave to get 6 new guidelines) and guideline 2.1 only has 4 success criterion. We'd need 6 new guidelines on 2.1, and 7 new success criteria on 2.1 for this to become an issue. Since there is already talk of WCAG 3.0, this is unlikely to be an issue for WCAG 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement needs discussion More discussion is needed to continue wcag 2.1
Projects
None yet
Development

No branches or pull requests

4 participants