Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't flag invalid roles in unsupportedrole #1328

Merged
merged 6 commits into from Jan 22, 2019
Merged

fix: don't flag invalid roles in unsupportedrole #1328

merged 6 commits into from Jan 22, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 17, 2019 •
edited by WilcoFiers

The check for unsupportedrole also checked if the role was valid, causing invalid roles to be flagged as unsupported.

Closes issue: #1324

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@straker straker requested a review from a team as a code owner January 17, 2019 17:00
@straker straker requested a review from a team January 17, 2019 17:00
jeeyyy
jeeyyy previously requested changes Jan 18, 2019
View reviewed changes
lib/checks/aria/unsupportedrole.js Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers dismissed jeeyyy’s stale review January 22, 2019 16:35

Review is outdated

@WilcoFiers WilcoFiers changed the title fix: dont flag invalid roles in unsupportedrole fix: don't flag invalid roles in unsupportedrole Jan 22, 2019
@WilcoFiers WilcoFiers merged commit 2dfcbaa into develop Jan 22, 2019
@WilcoFiers WilcoFiers deleted the fix-aria-unsupported-check branch January 22, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson left review comments

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@jeeyyy jeeyyy jeeyyy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@straker @WilcoFiers @stephenmathieson @jeeyyy